[Top] [All Lists]

Re: [PATCH] xfs: fix bogus m_maxagi check in xfs_iget

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] xfs: fix bogus m_maxagi check in xfs_iget
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 07 Oct 2010 14:22:18 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101006183123.GA2166@xxxxxx>
References: <20101006183123.GA2166@xxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-10-06 at 14:31 -0400, Christoph Hellwig wrote:
> These days inode64 should only control which AGs we allocate new inodes
> from, while we still try to support reading all existing inodes.  To make
> this actually work the check ontop of xfs_iget needs to be relaxed to allow
> inodes in all allocation groups instead of just those that we allow
> allocating inodes from.  Note that we can't simply remove the check - it
> prevents us from accessing invalid data when fed invalid inode numbers
> from NFS or bulkstat.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>