xfs
[Top] [All Lists]

Re: -mm: xfs lockdep warning

To: Tejun Heo <tj@xxxxxxxxxx>
Subject: Re: -mm: xfs lockdep warning
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 4 Oct 2010 20:21:07 +1100
Cc: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Yang Ruirui <ruirui.r.yang@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alex Elder <aelder@xxxxxxx>
In-reply-to: <4CA997DF.5030008@xxxxxxxxxx>
References: <201009161546.16909.ruirui.r.yang@xxxxxxxxx> <20100917005227.GJ24409@dastard> <20100920191355.GA28443@xxxxxxxxxxxxx> <AANLkTi=45J+=ytj=NC4bYTVJFRakNQQiFd35K7mrf+Gq@xxxxxxxxxxxxxx> <4CA997DF.5030008@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Oct 04, 2010 at 11:01:19AM +0200, Tejun Heo wrote:
> Hello,
> 
> On 09/25/2010 03:08 PM, Torsten Kaiser wrote:
> > [adding Tejun Heo, because I'm partly blaming his workqueues]
> 
> :-) Sorry about the delay.  I was away the last week.
> 
> > After that I enabled lockdep and retried the same update: This time no
> > hang, only the same lockdep report that Yang Ruirui had.
> > 
> > So I'm currently at a loss how I should continue from here. The XFS
> > false positive drowns any other lockdep problems, but XFS had some
> > hang problems with the new workqueues. (Personally I had no other hang
> > with earlier 2.6.36-rcs)

What XFS hang problem? I've seen temporary livelocks from the new
workqueue code, but thay have been fixed. I haven't come across any
deadlocks or hangs. Do you have a pointer to a bug report in case my
memory is failing me?

> If workqueue lockdep annotations are triggering spuriously, just nuke
> all lockdep annotations in workqueue.c.  Currently the annotations are
> the same as before and trigger even when an actual deadlock won't
> happen anymore around flushes (but then again all the current users
> should be operating under the same constraints as before).  I'm
> looking into how to improve the lockdep annotations but in the end it
> might be best to leave it as it is.  I'll try to analyze the warnings.

It looks like there's been some discussion that has been private so
I'm clueless as to the context being discussed here.  Can someone
fill me in on whatever is going on?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>