xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()

To: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 30 Sep 2010 09:24:46 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201009291954.32292.arekm@xxxxxxxx>
References: <1285770951-27000-1-git-send-email-lczerner@xxxxxxxxxx> <1285770951-27000-2-git-send-email-lczerner@xxxxxxxxxx> <201009291954.32292.arekm@xxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Sep 29, 2010 at 07:54:32PM +0200, Arkadiusz Miskiewicz wrote:
> On Wednesday 29 of September 2010, Lukas Czerner wrote:
> > Pass MKFS_OPTIONS to mkfs.$FSTYP in _scratch_mkfs_sized().
> > Preserve user defined MKFS_OPTIONS in _scratch_mkfs_geom().
> > ---
> >  common.rc |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/common.rc b/common.rc
> [...]
> >      case $FSTYP in
> >      xfs)
> > -   MKFS_OPTIONS="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
> > +   MKFS_OPTIONS+="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
> 
> common.rc uses /bin/sh and += notation is a bashizm. Won't work on strict 
> posix shells.

We've converted all of xfstests to use bash rather than bin/sh because of
all the bashisms in the code, so this is fine.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>