xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()
From: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
Date: Wed, 29 Sep 2010 19:54:32 +0200
In-reply-to: <1285770951-27000-2-git-send-email-lczerner@xxxxxxxxxx>
References: <1285770951-27000-1-git-send-email-lczerner@xxxxxxxxxx> <1285770951-27000-2-git-send-email-lczerner@xxxxxxxxxx>
User-agent: KMail/1.13.5 (Linux/2.6.36-rc5-00151-g32163f4; KDE/4.5.1; x86_64; ; )
On Wednesday 29 of September 2010, Lukas Czerner wrote:
> Pass MKFS_OPTIONS to mkfs.$FSTYP in _scratch_mkfs_sized().
> Preserve user defined MKFS_OPTIONS in _scratch_mkfs_geom().
> ---
>  common.rc |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/common.rc b/common.rc
[...]
>      case $FSTYP in
>      xfs)
> -     MKFS_OPTIONS="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
> +     MKFS_OPTIONS+="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"

common.rc uses /bin/sh and += notation is a bashizm. Won't work on strict 
posix shells.

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

<Prev in Thread] Current Thread [Next in Thread>