xfs
[Top] [All Lists]

Re: [PATCH 3/3] [PATCH 3/3] xfs: do not use xfs_mod_incore_sb_batch for

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] [PATCH 3/3] xfs: do not use xfs_mod_incore_sb_batch for per-cpu counters
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 29 Sep 2010 07:45:43 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100929112720.GN5665@dastard>
References: <20100929072221.583672974@xxxxxxxxxxxxxxxxxxxxxx> <20100929072238.456748707@xxxxxxxxxxxxxxxxxxxxxx> <20100929112720.GN5665@dastard>
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Sep 29, 2010 at 09:27:20PM +1000, Dave Chinner wrote:
> > +out_undo_ifreecount:
> > +   if (ifreedelta)
> > +           xfs_icsb_modify_counters(mp, XFS_SBS_IFREE, ifreedelta, rsvd);
> > +out_undo_icount:
> > +   if (idelta)
> > +           xfs_icsb_modify_counters(mp, XFS_SBS_ICOUNT, idelta, rsvd);
> 
> These two should be -ifreedelta and -idelta, right?

Indeed, fixed.

<Prev in Thread] Current Thread [Next in Thread>