[Top] [All Lists]

Re: [PATCH 1/3] [PATCH 1/3] xfs: remove XFS_MOUNT_NO_PERCPU_SB

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] [PATCH 1/3] xfs: remove XFS_MOUNT_NO_PERCPU_SB
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 29 Sep 2010 21:29:20 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100929072237.865681186@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100929072221.583672974@xxxxxxxxxxxxxxxxxxxxxx> <20100929072237.865681186@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Sep 29, 2010 at 03:22:22AM -0400, Christoph Hellwig wrote:
> Fail the mount if we can't allocate memory for the per-CPU counters.
> This is consistent with how we handle everything else in the mount
> path and makes the superblock counter modification a lot simpler.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.  I had an "XXX: kill XFS_MOUNT_NO_PERCPU_SB?" in my
patch, so no complaints about this from me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>