xfs
[Top] [All Lists]

Re: [PATCH 3/3] [PATCH 3/3] xfs: do not use xfs_mod_incore_sb_batch for

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] [PATCH 3/3] xfs: do not use xfs_mod_incore_sb_batch for per-cpu counters
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 29 Sep 2010 21:27:20 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100929072238.456748707@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100929072221.583672974@xxxxxxxxxxxxxxxxxxxxxx> <20100929072238.456748707@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Sep 29, 2010 at 03:22:24AM -0400, Christoph Hellwig wrote:
> Update the per-cpu counters manually in xfs_trans_unreserve_and_mod_sb and
> remove support for per-cpu counters from xfs_mod_incore_sb_batch to
> simplify it.  And added benefit is that we don't have to take m_sb_lock
> for transactions that only modify per-cpu counters.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
....

> +
> +     return;
> +
> +out_undo_ifreecount:
> +     if (ifreedelta)
> +             xfs_icsb_modify_counters(mp, XFS_SBS_IFREE, ifreedelta, rsvd);
> +out_undo_icount:
> +     if (idelta)
> +             xfs_icsb_modify_counters(mp, XFS_SBS_ICOUNT, idelta, rsvd);

These two should be -ifreedelta and -idelta, right?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>