xfs
[Top] [All Lists]

Re: [PATCH 14/18] xfs: implement batched inode lookups for AG walking

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 14/18] xfs: implement batched inode lookups for AG walking
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 27 Sep 2010 12:50:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285552073-14663-15-git-send-email-david@xxxxxxxxxxxxx>
References: <1285552073-14663-1-git-send-email-david@xxxxxxxxxxxxx> <1285552073-14663-15-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2010-09-27 at 11:47 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> With the reclaim code separated from the generic walking code, it is
> simple to implement batched lookups for the generic walk code.
> Separate out the inode validation from the execute operations and
> modify the tree lookups to get a batch of inodes at a time.
> 
> Reclaim operations will be optimised separately.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good.  (I sent some comments about this
function in a separate message, but this looks
OK to me anyway.)

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>