xfs
[Top] [All Lists]

Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 27 Sep 2010 11:05:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100924091522.GT2614@dastard>
References: <1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx> <1285137869-10310-13-git-send-email-david@xxxxxxxxxxxxx> <1285262225.1973.60.camel@doink> <20100924091522.GT2614@dastard>
Reply-to: aelder@xxxxxxx
On Fri, 2010-09-24 at 19:15 +1000, Dave Chinner wrote:
> On Thu, Sep 23, 2010 at 12:17:05PM -0500, Alex Elder wrote:
> > On Wed, 2010-09-22 at 16:44 +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > With the reclaim code separated from the generic walking code, it is
> > > simple to implement batched lookups for the generic walk code.

. . .

> > The gang lookup should never return
> > anything beyond the end of the AG.  It seems
> > like you ought to be able to detect when you've
> > covered all the whole AG elsewhere,
> 
> AFAICT, there are only two ways - the gang lookup returns nothing,
> or we see the last valid inode number in the AG. If you can come up
> with something that doesn't invlove a tree or inode number lookup,
> I'm all ears....

I didn't have anything specific in mind and was basing
this somewhat on gut feeling so you probably have the
best solution as-is.  But I'll look at your new code
and if I come up with any bright ideas I'll let you
know.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>