xfs
[Top] [All Lists]

Re: [PATCH 13/18] xfs: split out inode walk inode grabbing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 13/18] xfs: split out inode walk inode grabbing
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 27 Sep 2010 10:58:56 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285552073-14663-14-git-send-email-david@xxxxxxxxxxxxx>
References: <1285552073-14663-1-git-send-email-david@xxxxxxxxxxxxx> <1285552073-14663-14-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2010-09-27 at 11:47 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When doing read side inode cache walks, the code to validate and
> grab an inode is common to all callers. Split it out of the execute
> callbacks in preparation for batching lookups. Similarly, split out
> the inode reference dropping from the execute callbacks into the
> main lookup look to be symmetric with the grab.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>