xfs
[Top] [All Lists]

Re: [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modific

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modifications
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 27 Sep 2010 11:09:14 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100925234248.GA23975@xxxxxxxxxxxxx>
References: <1285331476-23015-1-git-send-email-david@xxxxxxxxxxxxx> <1285331476-23015-6-git-send-email-david@xxxxxxxxxxxxx> <20100925234248.GA23975@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Sep 25, 2010 at 07:42:48PM -0400, Christoph Hellwig wrote:
> As mentioned before I think xfs_trans_ichgtime should go into
> xfs_trans_inode.c/xfs_trans.h.  Instead of keeping xfs_ichgtime around
> for one caller it might be easier to just opencode it similar to
> what other filesystems do, e.g. just:
> 
>       inode->i_mtime = inode->i_ctime = current_fs_time(inode->i_sb);
>       mark_inode_dirty_sync(inode);
> 
> there's really no point in doing the check for an actual time change
> first as it's a relatively rare operation.

Ok. I'll respin it to do this.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>