xfs
[Top] [All Lists]

Re: [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modific

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/18] xfs: don't use vfs writeback for pure metadata modifications
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Sep 2010 19:42:48 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285331476-23015-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1285331476-23015-1-git-send-email-david@xxxxxxxxxxxxx> <1285331476-23015-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
As mentioned before I think xfs_trans_ichgtime should go into
xfs_trans_inode.c/xfs_trans.h.  Instead of keeping xfs_ichgtime around
for one caller it might be easier to just opencode it similar to
what other filesystems do, e.g. just:

        inode->i_mtime = inode->i_ctime = current_fs_time(inode->i_sb);
        mark_inode_dirty_sync(inode);

there's really no point in doing the check for an actual time change
first as it's a relatively rare operation.

<Prev in Thread] Current Thread [Next in Thread>