[Top] [All Lists]

Re: [PATCH VER 4] xfsprogs: projid32bit handling

To: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH VER 4] xfsprogs: projid32bit handling
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 23 Sep 2010 17:57:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285177520-11513-1-git-send-email-arekm@xxxxxxxx>
References: <1285177343-11108-1-git-send-email-arekm@xxxxxxxx> <1285177520-11513-1-git-send-email-arekm@xxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-09-22 at 19:45 +0200, Arkadiusz Miśkiewicz wrote:
> Add projid32bit handling to userspace. mkfs is able to enable this
> feature for new filesystems. xfs_db knows what projid_lo/hi are.

I forgot to mention this before.  Now that I see man
pages I think I should do so.  You should use the term
"identifiers" rather than the (non-word) "identificators"

A number of the comments I had on the kernel XFS code
apply to the user-space counterpart code here, so I
won't offer those comments here.  I will just ask that
you make the two be consistent with each other where there
is matching code.

I haven't given this code a very thorough review, just
a scan for the most part.  I'd like to hear your thoughts
on my suggestions from your XFS patch.


> Signed-off-by: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
> ---
> What has changed?
> - sb_bad_features2 is also updated
> - bstat_get_projid helper added

<Prev in Thread] Current Thread [Next in Thread>