| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/16] xfs: rename xfs_buf_get_nodaddr to be more appropriate |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 23 Sep 2010 11:22:50 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1285137869-10310-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx> <1285137869-10310-6-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | aelder@xxxxxxx |
On Wed, 2010-09-22 at 16:44 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_buf_get_nodaddr() is really used to allocate a buffer that is > uncached. While it is not directly assigned a disk address, the fact > that they are not cached is a more important distinction. With the > upcoming uncached buffer read primitive, we should be consistent > with this disctinction. > > While there, make page allocation in xfs_buf_get_nodaddr() safe > against memory reclaim re-entrancy into the filesystem by changing > the allocation to GFP_NOFS. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/16] xfs: don't use vfs writeback for pure metadata modifications, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Alex Elder |
| Previous by Thread: | Re: [PATCH 05/16] xfs: rename xfs_buf_get_nodaddr to be more appropriate, Dave Chinner |
| Next by Thread: | [PATCH 02/16] xfs: remove debug assert for per-ag reference counting, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |