xfs
[Top] [All Lists]

Re: [PATCH] xfs: force background CIL push under sustained load

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: force background CIL push under sustained load
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 23 Sep 2010 06:43:27 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285208863-31489-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1285208863-31489-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Sep 23, 2010 at 12:27:43PM +1000, Dave Chinner wrote:
> The fix is to start blocking background pushes once the threshold has been
> exceeded by 50%. This is still only 37.5% of log space at worst, so keeps us
> well short of the limit a transaction must not exceed.


Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> + * the background push threshold to 1/8th (12.5%) the size of the log, and 
> then start

if you can please shorten this line a bit for the final version.

<Prev in Thread] Current Thread [Next in Thread>