xfs
[Top] [All Lists]

Re: [PATCH 01/16] xfs: reduce the number of CIL lock round trips during

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/16] xfs: reduce the number of CIL lock round trips during commit
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 22 Sep 2010 14:57:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1285137869-10310-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx> <1285137869-10310-2-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-09-22 at 16:44 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When commiting a transaction, we do a lock CIL state lock round trip
> on every single log vector we insert into the CIL. This is resulting
> in the lock being as hot as the inode and dcache locks on 8-way
> create workloads. Rework the insertion loops to bring the number
> of lock round trips to one per transaction for log vectors, and one
> more do the busy extents.
> 
> Also change the allocation of the log vector buffer not to zero it
> as we copy over the entire allocated buffer anyway.
> 
> This patch also includes a structural cleanup to the CIL item
> insertion provided by Christoph Hellwig.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>