Re: [PATCH 11/16] xfs: split inode AG walking into separate code for rec

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 22 Sep 2010 13:28:05 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1285137869-10310-12-git-send-email-david@xxxxxxxxxxxxx>
References:	<1285137869-10310-1-git-send-email-david@xxxxxxxxxxxxx> <1285137869-10310-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-08-17)

On Wed, Sep 22, 2010 at 04:44:24PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The reclaim walk requires different locking and has a slightly
> different walk algorithm, so separate it out so that it can be
> optimised separately.

Yeah, the code was getting far too cruft already with all the
conditionals.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 08/16] xfs: kill XBF_FS_MANAGED buffers, (continued) [PATCH 08/16] xfs: kill XBF_FS_MANAGED buffers, Dave Chinner [PATCH 09/16] xfs: use unhashed buffers for size checks, Dave Chinner [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Dave Chinner Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Christoph Hellwig Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Dave Chinner Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Alex Elder Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Dave Chinner Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Alex Elder Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Alex Elder [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Dave Chinner Re: [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Christoph Hellwig <= Re: [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Alex Elder [PATCH 10/16] xfs: remove buftarg hash for external devices, Dave Chinner [PATCH 03/16] xfs: lockless per-ag lookups, Dave Chinner [PATCH 16/16] xfs; pack xfs_buf structure more tightly, Dave Chinner [PATCH 14/16] xfs: serialise inode reclaim within an AG, Dave Chinner Re: [PATCH 14/16] xfs: serialise inode reclaim within an AG, Alex Elder [PATCH 07/16] xfs: store xfs_mount in the buftarg instead of in the xfs_buf, Dave Chinner [PATCH 13/16] xfs: batch inode reclaim lookup, Dave Chinner Re: [PATCH 13/16] xfs: batch inode reclaim lookup, Christoph Hellwig Re: [PATCH 13/16] xfs: batch inode reclaim lookup, Dave Chinner

Previous by Date:	Re: [PATCH 05/16] xfs: rename xfs_buf_get_nodaddr to be more appropriate, Christoph Hellwig
Next by Date:	Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking, Christoph Hellwig
Previous by Thread:	[PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Dave Chinner
Next by Thread:	Re: [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]