xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.34-1972

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.34-19726-ge89318c
From: xfs@xxxxxxxxxxx
Date: Thu, 16 Sep 2010 17:20:36 -0500
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  e89318c xfs: eliminate some newly-reported gcc warnings
  a4874ad xfs: remove the ->kill_root btree operation
  fc4b731f xfs: stop using xfs_qm_dqtobp in xfs_qm_dqflush
  75a93d4 xfs: simplify xfs_qm_dqusage_adjust
  51749e4 xfs: log IO completion workqueue is a high priority queue
  a122eb2 xfs: prevent reading uninitialized stack memory
      from  0e251465b06b75dfed16b9373c25cce85eeda484 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e89318c670af3959db3aa483da509565f5a2536c
Author: Poyo VL <poyo_vl@xxxxxxxxx>
Date:   Thu Sep 2 07:41:55 2010 +0000

    xfs: eliminate some newly-reported gcc warnings
    
    Ionut Gabriel Popescu <poyo_vl@xxxxxxxxx> submitted a simple change
    to eliminate some "may be used uninitialized" warnings when building
    XFS.  The reported condition seems to be something that GCC did not
    used to recognize or report.  The warnings were produced by:
    
        gcc version 4.5.0 20100604
        [gcc-4_5-branch revision 160292] (SUSE Linux)
    
    Signed-off-by: Ionut Gabriel Popescu <poyo_vl@xxxxxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

commit a4874ada8f44cb7cca9fcad65a3c6a09fc9f1ccd
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:   Tue Sep 7 23:34:07 2010 +0000

    xfs: remove the ->kill_root btree operation
    
    The implementation os ->kill_root only differ by either simply
    zeroing out the now unused buffer in the btree cursor in the inode
    allocation btree or using xfs_btree_setbuf in the allocation btree.
    
    Initially both of them used xfs_btree_setbuf, but the use in the
    ialloc btree was removed early on because it interacted badly with
    xfs_trans_binval.
    
    In addition to zeroing out the buffer in the cursor xfs_btree_setbuf
    updates the bc_ra array in the btree cursor, and calls
    xfs_trans_brelse on the buffer previous occupying the slot.
    
    The bc_ra update should be done for the alloc btree updated too,
    although the lack of it does not cause serious problems.  The
    xfs_trans_brelse call on the other hand is effectively a no-op in
    the end - it keeps decrementing the bli_recur refcount until it hits
    zero, and then just skips out because the buffer will always be
    dirty at this point.  So removing it for the allocation btree is
    just fine.
    
    So unify the code and move it to xfs_btree.c.  While we're at it
    also replace the call to xfs_btree_setbuf with a NULL bp argument in
    xfs_btree_del_cursor with a direct call to xfs_trans_brelse given
    that the cursor is beeing freed just after this and the state
    updates are superflous.  After this xfs_btree_setbuf is only used
    with a non-NULL bp argument and can thus be simplified.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

commit fc4b731f473ff5ec3a3b0d03bf7c60870a7e71f1
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:   Mon Sep 6 01:44:45 2010 +0000

    xfs: stop using xfs_qm_dqtobp in xfs_qm_dqflush
    
    In xfs_qm_dqflush we know that q_blkno must be initialized already from a
    previous xfs_qm_dqread.  So instead of calling xfs_qm_dqtobp we can
    simply read the quota buffer directly.  This also saves us from a duplicate
    xfs_qm_dqcheck call check and allows xfs_qm_dqtobp to be simplified now
    that it is always called for a newly initialized inode.  In addition to
    that properly unwind all locks in xfs_qm_dqflush when xfs_qm_dqcheck
    fails.
    
    This mirrors a similar cleanup in the inode lookup done earlier.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

commit 75a93d4130e457fb67a348d5b96ef2cfe3192722
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Sep 6 01:44:22 2010 +0000

    xfs: simplify xfs_qm_dqusage_adjust
    
    There is no need to have the users and group/project quota locked at the
    same time.  Get rid of xfs_qm_dqget_noattach and just do a xfs_qm_dqget
    inside xfs_qm_quotacheck_dqadjust for the quota we are operating on
    right now.  The new version of xfs_qm_quotacheck_dqadjust holds the
    inode lock over it's operations, which is not a problem as it simply
    increments counters and there is no concern about log contention
    during mount time.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/quota/xfs_dquot.c  |  164 +++++++++++++++++-------------------
 fs/xfs/quota/xfs_qm.c     |  203 ++++++++++++++-------------------------------
 fs/xfs/xfs_alloc.c        |    4 +-
 fs/xfs/xfs_alloc_btree.c  |   33 -------
 fs/xfs/xfs_btree.c        |   52 ++++++++++--
 fs/xfs/xfs_btree.h        |   14 +---
 fs/xfs/xfs_ialloc_btree.c |   33 -------
 7 files changed, 183 insertions(+), 320 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.34-19726-ge89318c, xfs <=