xfs
[Top] [All Lists]

The segment fault with NULL point using when recovering failure

To: xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: The segment fault with NULL point using when recovering failure
From: Mike Gao <ygao.linux@xxxxxxxxx>
Date: Wed, 15 Sep 2010 10:59:07 -0500
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=3Jq/kU3qcU6AN76/IXL5tThaurtbv3qrY2JyhntGiO4=; b=wZiovC2MSN6jRtz41TvXhg8r06kyEVS9C+ZcBqKsVduqpQ395Q/qy0mf6VbmfPH1UT dh1h8Wy+PatcMw5sdNvrqD8HoIFy4zN0e4pLsIgjgP53UrkxsN5MaE/8OOMHeQ9UUlei w2KVGF3JAUrhCDQJTAL3LoujLTWJo7PT5ktEs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=wXhVJJo5sQ0uzCATxo7YpB3KWSLLgCDhArUSo0b28a+7jXNyMSphk0SfGbx3Rmagj0 8/KVvDvxMbn6Azk56tOLCPcXkH1M+E9Wy0bp6jZJshSMx4SxJnedUCrIVXLQWMD9peps GU1WJsEM1MLrsaMYQfori+VXknesihpI48M4c=
xlog_recover_process_iunlinks(
    xlog_t        *log)
{
                /*
                 * Reacquire the agibuffer and continue around
                 * the loop. This should never fail as we know
                 * the buffer was good earlier on.
                 */
                error = xfs_read_agi(mp, NULL, agno, &agibp);
                ASSERT(error == 0);
                agi = XFS_BUF_TO_AGI(agibp);
 
}
If no defined DEBUG, ASSERT will not work and agibp could be ZERO if there is a error in xfs_read_agi.
And the comment shouldn't say it never fail because  xfs_read_agi will return error in function and it does when there is forced shutdown.

Thanks,
Mike Gao


<Prev in Thread] Current Thread [Next in Thread>