xfs
[Top] [All Lists]

Re: [PATCH 07/18] xfs: don't use vfs writeback for pure metadata modific

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/18] xfs: don't use vfs writeback for pure metadata modifications
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 10:14:23 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100914145447.GE3400@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-8-git-send-email-david@xxxxxxxxxxxxx> <20100914145447.GE3400@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Sep 14, 2010 at 10:54:47AM -0400, Christoph Hellwig wrote:
> On Tue, Sep 14, 2010 at 08:56:06PM +1000, Dave Chinner wrote:
> > Hence we can stop marking VFS inodes dirty during transaction commit or when
> > changing timestamps during transactions. This will keep the inodes in the
> > superblock dirty list to those containing data or unlogged metadata changes.
> 
> But we also use xfs_ichgtime for non-transacion size updates, e.g.
> for truncate of zero length files.  With this patch we lose track of
> the timestamp updates for this case.

Oh, I missed that one in the twisty passages of the setattr code.
I'll do another (more careful) pass across all the callers, and for
those that are outside a transaction I'll add a separate call to
xfs_mark_inode_dirty_sync() for them.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>