xfs
[Top] [All Lists]

Re: [PATCH 17/18] xfs: add a lru to the XFS buffer cache

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 17/18] xfs: add a lru to the XFS buffer cache
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 10:05:11 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100914231644.GB29338@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-18-git-send-email-david@xxxxxxxxxxxxx> <20100914231644.GB29338@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Sep 14, 2010 at 07:16:44PM -0400, Christoph Hellwig wrote:
> 
> Looks correct to me, although probably indeed a bit simplistic.
>
> > +           /* add to LRU */
> > +           spin_lock(&btp->bt_lru_lock);
> > +           list_add_tail(&new_bp->b_lru, &btp->bt_lru);
> > +           btp->bt_lru_nr++;
> > +           atomic_inc(&new_bp->b_hold);
> > +           spin_unlock(&btp->bt_lru_lock);
> 
> Just for clarity it would be nice to have this as an xfs_buf_lru_add
> helper.
> 
> > +                   /* remove from LRU */
> > +                   spin_lock(&btp->bt_lru_lock);
> > +                   list_del_init(&bp->b_lru);
> > +                   btp->bt_lru_nr--;
> > +                   spin_unlock(&btp->bt_lru_lock);
> 
> And this ad xfs_buf_lru_del.

Yes, will do.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>