xfs
[Top] [All Lists]

Re: [PATCH 11/18] xfs: kill XBF_FS_MANAGED buffers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/18] xfs: kill XBF_FS_MANAGED buffers
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 14 Sep 2010 17:26:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1284461777-1496-12-git-send-email-david@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-12-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Filesystem level managed buffers are buffers that have their
> lifecycle controlled by the filesystem layer, not the buffer cache.
> We currently cache these buffers, which makes cleanup and cache
> walking somewhat troublesome. Convert the fs managed buffers to
> uncached buffers obtained by via xfs_buf_get_uncached(), and remove
> the XBF_FS_MANAGED special cases from the buffer cache.

Looks good.  Nicer with the xfs_buf_read_uncached() helper.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_buf.c |   20 +++------------
>  fs/xfs/linux-2.6/xfs_buf.h |    4 ---
>  fs/xfs/xfs_mount.c         |   56 ++++++++++++-------------------------------
>  3 files changed, 20 insertions(+), 60 deletions(-)


<Prev in Thread] Current Thread [Next in Thread>