xfs
[Top] [All Lists]

Re: [PATCH 02/18] xfs: reduce the number of CIL lock round trips during

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/18] xfs: reduce the number of CIL lock round trips during commit
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 14 Sep 2010 12:21:22 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1284461777-1496-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-3-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When commiting a transaction, we do a lock CIL state lock round trip
> on every single log vector we insert into the CIL. This is resulting
> in the lock being as hot as the inode and dcache locks on 8-way
> create workloads. Rework the insertion loops to bring the number
> of lock round trips to one per transaction for log vectors, and one
> more do the busy extents.
> 
> Also change the allocation of the log vector buffer not to zero it
> as we copy over the entire allocated buffer anyway.
> 

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_log_cil.c |  116 +++++++++++++++++++++++++++++--------------------
>  1 files changed, 69 insertions(+), 47 deletions(-)


<Prev in Thread] Current Thread [Next in Thread>