xfs
[Top] [All Lists]

Re: [PATCH 07/18] xfs: don't use vfs writeback for pure metadata modific

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/18] xfs: don't use vfs writeback for pure metadata modifications
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 14 Sep 2010 10:54:47 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1284461777-1496-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1284461777-1496-1-git-send-email-david@xxxxxxxxxxxxx> <1284461777-1496-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Sep 14, 2010 at 08:56:06PM +1000, Dave Chinner wrote:
> Hence we can stop marking VFS inodes dirty during transaction commit or when
> changing timestamps during transactions. This will keep the inodes in the
> superblock dirty list to those containing data or unlogged metadata changes.

But we also use xfs_ichgtime for non-transacion size updates, e.g.
for truncate of zero length files.  With this patch we lose track of
the timestamp updates for this case.

<Prev in Thread] Current Thread [Next in Thread>