xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: convert buffer cache hash to rbtree

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: convert buffer cache hash to rbtree
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 13 Sep 2010 11:59:45 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100909015150.GB11362@xxxxxxxxxxxxx>
References: <1283958778-28610-1-git-send-email-david@xxxxxxxxxxxxx> <1283958778-28610-5-git-send-email-david@xxxxxxxxxxxxx> <20100909015150.GB11362@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
> > @@ -210,8 +210,6 @@ xfs_perag_get(struct xfs_mount *mp, xfs_agnumber_t agno)
> >     pag = radix_tree_lookup(&mp->m_perag_tree, agno);
> >     if (pag) {
> >             ASSERT(atomic_read(&pag->pag_ref) >= 0);
> > -           /* catch leaks in the positive direction during testing */
> > -           ASSERT(atomic_read(&pag->pag_ref) < 1000);
> 
> Di you manage to hit this during testing?  Either way it should probably
> be a separate patch.

I'm pretty sure this is due to each buffer now holding
a perag reference.  It might be nice to preserve this
functionality by checking against the number of blocks
in the AG or something similar.  But it's debug so it's
not quite as critical.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>