[Top] [All Lists]

Re: [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 10 Sep 2010 16:17:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1283958778-28610-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1283958778-28610-1-git-send-email-david@xxxxxxxxxxxxx> <1283958778-28610-2-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2010-09-09 at 01:12 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Filesystem level managed buffers are buffers that have their
> lifecycle controlled by the filesystem layer, not the buffer cache.
> We currently hash these buffers, which makes cleanup and hash
> walking somewhat troublesome. Convert the fs managed buffers to
> unhashed buffers obtained by via xfs_buf_get_noaddr(), and remove the
> XBF_FS_MANAGED special cases from the buffer cache.

I've looked this over and it looks good to me.
I agree with all of Christoph's comments from
the other day.  I'll look for your update.


> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

. . .

<Prev in Thread] Current Thread [Next in Thread>