xfs
[Top] [All Lists]

Re: [PATCH] xfs: log IO completion workqueue is a high priority queue

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: log IO completion workqueue is a high priority queue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 8 Sep 2010 21:26:10 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1283936422-20160-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1283936422-20160-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Sep 08, 2010 at 07:00:22PM +1000, Dave Chinner wrote:
> queued ahead of all data/metadata IO completions and processed before the
> data/metadata completions. Hence the log never gets stalled, and operations
> needed to clean memory can continue as quickly as possible. This avoids the
> livelock conditions and allos the system to keep running under heavy load as
> per normal.

>From a quick review of how the WQ_HIGHPRI flag is handled this look good
to me.  I'm still rather suspicious of the new workqueue code, and the
complete lack of documentation for it, though.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>