Re: [PATCH] xfs: log IO completion workqueue is a high priority queue

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Sep 08, 2010 at 07:00:22PM +1000, Dave Chinner wrote:
> queued ahead of all data/metadata IO completions and processed before the
> data/metadata completions. Hence the log never gets stalled, and operations
> needed to clean memory can continue as quickly as possible. This avoids the
> livelock conditions and allos the system to keep running under heavy load as
> per normal.

>From a quick review of how the WQ_HIGHPRI flag is handled this look good
to me.  I'm still rather suspicious of the new workqueue code, and the
complete lack of documentation for it, though.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>