xfs
[Top] [All Lists]

Re: [PATCH] Extend project quotas to support 32bit project identificator

To: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH] Extend project quotas to support 32bit project identificators. [version 3]
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 6 Sep 2010 22:50:33 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201009061236.21010.arekm@xxxxxxxx>
References: <1282770578-6958-1-git-send-email-arekm@xxxxxxxx> <1282948798-12622-1-git-send-email-arekm@xxxxxxxx> <20100905232200.GT7362@dastard> <201009061236.21010.arekm@xxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Sep 06, 2010 at 12:36:20PM +0200, Arkadiusz Miskiewicz wrote:
> On Monday 06 of September 2010, Dave Chinner wrote:
> > On Sat, Aug 28, 2010 at 12:39:58AM +0200, Arkadiusz Miśkiewicz wrote:
> 
> > > +static inline void xfs_sb_version_addprojid32bit(xfs_sb_t *sbp)
> > > +{
> > > + sbp->sb_versionnum |= XFS_SB_VERSION_MOREBITSBIT;
> > > + sbp->sb_features2 |= XFS_SB_VERSION2_PROJID32BIT;
> > > +}
> > 
> > This also needs to set the bit in the sbp->sb_bad_features2 field.
> 
> Hm, why all existing xfs_sb_version_addxyz() don't update it then?

The only one that updates sb_features2 - attr2 - is specially
handled in the mount path and sb_bad_features2 is updated there.
For correct handling in all cases, we should be updating both
both fields simultaneously...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>