xfs
[Top] [All Lists]

Re: [PATCH] Extend project quotas to support 32bit project identificator

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Extend project quotas to support 32bit project identificators. [version 3]
From: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
Date: Mon, 6 Sep 2010 12:36:20 +0200
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100905232200.GT7362@dastard>
References: <1282770578-6958-1-git-send-email-arekm@xxxxxxxx> <1282948798-12622-1-git-send-email-arekm@xxxxxxxx> <20100905232200.GT7362@dastard>
User-agent: KMail/1.13.5 (Linux/2.6.35-final-dirty; KDE/4.5.1; x86_64; ; )
On Monday 06 of September 2010, Dave Chinner wrote:
> On Sat, Aug 28, 2010 at 12:39:58AM +0200, Arkadiusz Miśkiewicz wrote:

> > +static inline void xfs_sb_version_addprojid32bit(xfs_sb_t *sbp)
> > +{
> > +   sbp->sb_versionnum |= XFS_SB_VERSION_MOREBITSBIT;
> > +   sbp->sb_features2 |= XFS_SB_VERSION2_PROJID32BIT;
> > +}
> 
> This also needs to set the bit in the sbp->sb_bad_features2 field.

Hm, why all existing xfs_sb_version_addxyz() don't update it then?

> Cheers,
> 
> Dave.


-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

<Prev in Thread] Current Thread [Next in Thread>