xfs
[Top] [All Lists]

Re: [PATCH] xfs: prevent 32bit overflow in space reservation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: prevent 32bit overflow in space reservation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 2 Sep 2010 08:16:31 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1283404663-28105-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1283404663-28105-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Sep 02, 2010 at 03:17:43PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> If we attempt to preallocate more than 2^32 blocks of space in a
> single syscall, the transaction block reservation will overflow
> leading to a hangs in the superblock block accounting code. This
> is trivially reproduced with xfs_io. Fix the problem by capping the
> allocation reservation to the maximum number of blocks a single
> xfs_bmapi() call can allocate (2^21 blocks).
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>