Re: What should to do with ASSERT failed

[Mike Gao <ygao.linux@xxxxxxxxx>]

What kind of logic there could be?

I notice that in old version, if page has no buffer in writepage, then xfs will create a empty buffer and attach to page. This logic there at least untill 2.6.33. But now xfs need this never happens (assert) when coming to writepage.  But I guess, when use mmap, there is no buffer attach to page because it operates on page directly on kernel. xfs should create buffer before submit bio. There must be sth I don't know. Maybe sbd can help me out.

Thanks very much,

Mike

On Mon, Aug 30, 2010 at 7:30 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:

On Mon, Aug 30, 2010 at 05:56:07PM -0500, Mike Gao wrote:

> Thanks very much for help. The kernel is pretty old, 2.6.19 but the xfs is
> pretty new.
> the block size is 512 and use mmap for test with write and read compare.
> (xfstest 074).

Can you reproduce it on a more recent kernel? The buffer flags are
modified by code outside XFS which could be significantly different in
2.6.19 comapred to 2.6.34/35, so it may not be aproblem with the
XFS code as such....

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx