[Top] [All Lists]

Re: What should to do with ASSERT failed

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: What should to do with ASSERT failed
From: Mike Gao <ygao.linux@xxxxxxxxx>
Date: Tue, 31 Aug 2010 17:50:06 -0500
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=yQXeVb+4thj/UvKw0cT+sIL73Gunmx+gEN5XeOiSrQE=; b=SEk03m2s4LyonadGCJXQBKyHKapZnKvGQtlVvlXCP/SG44VRhQUZ5+WEDuQLTsjmlZ xnQWCHrtyndcDG4/FAfDl+77zKRcfVCC6UWPcsxbAMeimm4Gq+saIXB3Oo3DAKT/naYN DctfH4R9LpC5k7sWfRDyM92FPgK6oArBKPqmI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=B5bZJMLo7wOOBhUV03d3YasqAGBKBj5FKblkX7VH1ausqtWUPTzssDtPgNOPezvynG pqwV9pvr8lPuF9VWi+5y8S1EWICCnITHW+G2BbPf68C6pkmi8Urh/P49ZZl+PKs6eTQY nnjl0wORWybpxlYx+oE20fWkLxkC4Ys9asjHQ=
In-reply-to: <20100831003050.GL705@dastard>
References: <AANLkTin-zf0chkk68pGfwDRt03QaKmNdsP3=goDEUS+p@xxxxxxxxxxxxxx> <4C7C26E8.9070308@xxxxxxxxxxx> <AANLkTinXDQoo7ZU+w2V7N7zBrxdS=Tc71MNZ7M4R5A9w@xxxxxxxxxxxxxx> <20100831003050.GL705@dastard>
What kind of logic there could be?

I notice that in old version, if page has no buffer in writepage, then xfs will create a empty buffer and attach to page. This logic there at least untill 2.6.33. But now xfs need this never happens (assert) when coming to writepage.  But I guess, when use mmap, there is no buffer attach to page because it operates on page directly on kernel. xfs should create buffer before submit bio. There must be sth I don't know. Maybe sbd can help me out.

Thanks very much,

On Mon, Aug 30, 2010 at 7:30 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
On Mon, Aug 30, 2010 at 05:56:07PM -0500, Mike Gao wrote:
> Thanks very much for help. The kernel is pretty old, 2.6.19 but the xfs is
> pretty new.
> the block size is 512 and use mmap for test with write and read compare.
> (xfstest 074).

Can you reproduce it on a more recent kernel? The buffer flags are
modified by code outside XFS which could be significantly different in
2.6.19 comapred to 2.6.34/35, so it may not be aproblem with the
XFS code as such....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>