| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: do not discard page cache data on EAGAIN |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 23 Aug 2010 22:11:22 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20100823091015.GA2829@xxxxxxxxxxxxx> |
| References: | <20100823091015.GA2829@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Mon, Aug 23, 2010 at 05:10:15AM -0400, Christoph Hellwig wrote: > If xfs_map_blocks returns EAGAIN because of lock contention we must redirty > the page and not disard the pagecache content and return an error from > writepage. We used to do this correctly, but the logic got lost during > the recent reshuffle of the writepage code. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reported-by: Mike Gao <ygao.linux@xxxxxxxxx> > Tested-by: Mike Gao <ygao.linux@xxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: handle negative wbc->nr_to_write during sync writeback, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] writeback: write_cache_pages doesn't terminate at nr_to_write <= 0, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs: do not discard page cache data on EAGAIN, Christoph Hellwig |
| Next by Thread: | [PATCH] xfs: handle negative wbc->nr_to_write during sync writeback, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |