[Top] [All Lists]

page discard on page error

To: xfs@xxxxxxxxxxx
Subject: page discard on page error
From: Mike Gao <ygao.linux@xxxxxxxxx>
Date: Wed, 18 Aug 2010 09:27:55 -0500
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=DKcILb5aKK/cWVEW7TjN0IGHh/7QOY4e1wZ23dfEnss=; b=mlkbMTIGIfN5MBfTmGCSkQdbyPEm2js/PlU7jGqQe3WF7bWMuSXh2fqziHr2xrXPdW ycFrnF6PJgG9x+3TerGgf3gUYhwjTiZumtz5vAoGZETkvBnR+zBsa7z/MLsyP5DUAi8Y gE4k4C85p8zmnA+BHdx0ckOHl+cu+5Op1ZC3A=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=SxbkbBtB6y/GYwhHpTA0QIxQycgOTaL1VzubZWmOQTY4JeNssRCmB1Im58zgKZxKdt 1b/tOYZc3VJ9R1JiCEstrTHCA4zkFKjuYiogYOeK5oyYTPaJ9Rwc+zs9zfL9DT2v/SCh dezc+AevkVxw+fn7JVnAdPDxFkXNBY/vyDvGw=
Hi, all,

I sync latest XFS last month and build into our embedded system. When I test, I found below issue.
It seems that the xfs_iomap failed when it did allocat with xfs_ilock_nowait().
I debug this and found that ip->i_lock is locked and there are sometime no unlock coming between two lock trying.
This issue will give wrong data in file on disk exactly on that offset.

Filesystem "ubdb1": page discard on page 09160ac0, inode 0x43, offset 229494784.
Filesystem "ubdb1": page discard on page 09160ae0, inode 0x43, offset 229498880.
Filesystem "ubdb1": page discard on page 0915fac0, inode 0x43, offset 229502976.
Filesystem "ubdb1": page discard on page 0915fae0, inode 0x43, offset 229507072.
Filesystem "ubdb1": page discard on page 0914d440, inode 0x43, offset 229511168.

Should we just discard the page? I don't think it is good because the file will be corrupted. 
Should we fix it? I am new to XFS and more than like to hear your opinion. 

Thanks very much,
Mike Gao
<Prev in Thread] Current Thread [Next in Thread>