xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix NIS detection damage

To: "Kinzel, David" <David.Kinzel@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix NIS detection damage
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 11 Aug 2010 09:19:06 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <F57F2AD357626644AF76410876025D75529750@xxxxxxxxxxxxxxxxxxx>
References: <1281057519-24730-1-git-send-email-david@xxxxxxxxxxxxx> <F57F2AD357626644AF76410876025D75529750@xxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Aug 10, 2010 at 07:44:10AM -0600, Kinzel, David wrote:
> Dave Chinner <dchinner@xxxxxxxxxx> said,
> >
> >NIS detection wasn't tested on machines without NIS enabled, 
> >so many tests are
> >failing on non-NIS machines. the _yp_active function has no 
> >specific return
> >value so always evaluates as 0 (active) and the "_cat_passwd" 
> >function is
> >called from within an awk script which is not valid as the 
> >shell may run with a
> >sanitised environment. Hence the functions do not need 
> >specific export calls,
> >either, as unsanitised subshells will automatically inherit 
> >the parent's
> >environment.
> >
> 
> Is there any reason why getent passwd/group cannot be used for these, as
> it would get local and nss defined accounts? This would add support for
> people using LDAP as well.

If you want your test box to use this stuff, then feel free to
submit patches that support this.

In general, though, I think that running anything other than a
single user account on a filesystem test box is not necessary - you
don't want random users to be able to log in to the machine you are
running potentially destructive tests on.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>