xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix NIS detection damage

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix NIS detection damage
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 6 Aug 2010 09:03:34 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1281057519-24730-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1281057519-24730-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Fri, Aug 06, 2010 at 11:18:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> NIS detection wasn't tested on machines without NIS enabled, so many tests are
> failing on non-NIS machines. the _yp_active function has no specific return
> value so always evaluates as 0 (active) and the "_cat_passwd" function is
> called from within an awk script which is not valid as the shell may run with 
> a
> sanitised environment. Hence the functions do not need specific export calls,
> either, as unsanitised subshells will automatically inherit the parent's
> environment.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>