xfs
[Top] [All Lists]

Re: [PATCH] xfs: Reduce log force overhead for delayed logging

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Reduce log force overhead for delayed logging
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 6 Aug 2010 09:01:06 -0400
Cc: xfs@xxxxxxxxxxx, npiggin@xxxxxxxxx
In-reply-to: <1280801234-23568-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1280801234-23568-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

minor nitpicks below:

>  int
>  xlog_cil_push(

This can be marked STATIC now.

> +/*
> + * CIL force routines
> + */
> +xfs_lsn_t xlog_cil_force_lsn(struct log *log, xfs_lsn_t sequence);
> +
> +static inline void
> +xlog_cil_force(struct log    *log)
> +{
> +     if (log->l_cilp)
> +             xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence);
> +}

I'd move the if (log->l_cilp) check to the caller.  One of the two
already does so, as does the caller of xlog_cil_force_lsn.

<Prev in Thread] Current Thread [Next in Thread>