| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: dummy transactions should not dirty VFS state |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Aug 2010 05:55:18 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1280826605-3506-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1280826605-3506-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-08-17) |
I looks good to me, but there are two subtile differences between xfs_commit_dummy_trans and xfs_fs_log_dummy that get lost. For one xfs_commit_dummy_trans doesn't actually commit a synchronous transaction (or rather forces out the log) unless SYNC_WAIT is set, in addition to that xfs_fs_log_dummy uses _xfs_trans_alloc, which doesn't get blocked by the filesystem freezing. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: dummy transactions should not dirty VFS state, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: dummy transactions should not dirty VFS state, Dave Chinner |
| Previous by Thread: | [PATCH] xfs: dummy transactions should not dirty VFS state, Dave Chinner |
| Next by Thread: | Re: [PATCH] xfs: dummy transactions should not dirty VFS state, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |