xfs
[Top] [All Lists]

Re: [PATCH 1/2] dio: track and serialise unaligned direct IO

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] dio: track and serialise unaligned direct IO
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Aug 2010 05:30:24 -0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, sandeen@xxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <1280733945-16231-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1280733945-16231-1-git-send-email-david@xxxxxxxxxxxxx> <1280733945-16231-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
> +DEFINE_SPINLOCK(dio_zero_block_lock);
> +LIST_HEAD(dio_zero_block_list);

These two should be static.

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>