xfs
[Top] [All Lists]

Re: [PATCH] xfstests 240: test non-aligned AIO hole-filling

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 240: test non-aligned AIO hole-filling
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 22 Jul 2010 22:37:20 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <4C490D4D.603@xxxxxxxxxx>
References: <4C489676.2000605@xxxxxxxxxx> <20100723024938.GD32635@dastard> <4C490D4D.603@xxxxxxxxxx>
User-agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
Eric Sandeen wrote:
> Dave Chinner wrote:

...

   
>> looks good - it needs to remove the $TEST_DIR/aiodio_sparse file
>> before the test starts, though, so that repeated tests fail
>> correctly. Otherwise:
>>
>>   
> hm, but:
> 
> +rm -f "$TEST_DIR/aiodio_sparse*"
> +
> +# 2 threads, 4k writes, 16k filesize, stride throug file by 4k, start at 512 
> offset
> +$here/src/aio-dio-regress/aiodio_sparse2 -i 2 -w 4k -s 16k -n 4k -o 512 
> "$TEST_DIR/aiodio_sparse"
> 
> It does remove it ... no?

hm, no, what are those quotes doing there...

Ok, will fix up thanks.

-Eric

<Prev in Thread] Current Thread [Next in Thread>