xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: fix unsigned underflow

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 21 Jul 2010 09:12:01 +1000
Cc: Kulikov Vasiliy <segooon@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <1279654533.1859.242.camel@doink>
References: <1279219605-12631-1-git-send-email-segooon@xxxxxxxxx> <20100715212116.GA7013@xxxxxxxxxxxxx> <1279654533.1859.242.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jul 20, 2010 at 02:35:33PM -0500, Alex Elder wrote:
> On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > > below zero. So, check exact expression instead of map_len.
> > > 
> > > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
> > 
> > Looks good,
> > 
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > 
> 
> Looks good to me too.  Do you want me to pull this
> in via the XFS tree, or do you have other plans?

Already got it, Alex.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>