xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: fix unsigned underflow

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
From: Vasiliy Kulikov <segooon@xxxxxxxxx>
Date: Wed, 21 Jul 2010 00:21:56 +0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=kqRgKzzwzbcRTjM174hh772lcDymeXZar4XkkZ/Q6VI=; b=pvoJZ+AqDZpYjTZU647MUbCWuwm/0AW/4v2PUXVzAVSIAa7olJUAlG9d+S9yw6YE5A AC+sMuPvlU0Qq877EvF6fetdAVqncR1jNEXGTWMfBXGjCbnBPAtvCBuu4Gne/i+vb51O eNqQm94dFVhuJANR2MMA1GKTdkGiZsuI761Hs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=jhktLalTcB/hGN8WScKFdJV37n4VrE8JckVUQVB87SmpNqCyIOaxnnipFTri9s+TWD jlxk84prtqQM2MO+OFJVp9WsD6QpS1RJ6J9LuwULS31QqVmbfrLgekmCLVaKnNICafUw cpDlxnkJp9SJD/XZkh2TWplGWSgOBWGpR3mPg=
In-reply-to: <1279654533.1859.242.camel@doink>
References: <1279219605-12631-1-git-send-email-segooon@xxxxxxxxx> <20100715212116.GA7013@xxxxxxxxxxxxx> <1279654533.1859.242.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jul 20, 2010 at 14:35 -0500, Alex Elder wrote:
> On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > > below zero. So, check exact expression instead of map_len.
> > > 
> > > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
> > 
> > Looks good,
> > 
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > 
> 
> Looks good to me too.  Do you want me to pull this
> in via the XFS tree, or do you have other plans?
Yes, pull it please.

> 
>                                       -Alex
> 

<Prev in Thread] Current Thread [Next in Thread>