xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: fix unsigned underflow

To: Kulikov Vasiliy <segooon@xxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 20 Jul 2010 14:35:33 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20100715212116.GA7013@xxxxxxxxxxxxx>
References: <1279219605-12631-1-git-send-email-segooon@xxxxxxxxx> <20100715212116.GA7013@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > below zero. So, check exact expression instead of map_len.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 

Looks good to me too.  Do you want me to pull this
in via the XFS tree, or do you have other plans?

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>