xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: remove obsolete osyncisosync mount option

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: remove obsolete osyncisosync mount option
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 20 Jul 2010 04:09:19 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100720073832.GH32635@dastard>
References: <20100718203848.927859114@xxxxxxxxxxxxxxxxxxxxxx> <20100718203926.229290039@xxxxxxxxxxxxxxxxxxxxxx> <20100720073832.GH32635@dastard>
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Jul 20, 2010 at 05:38:32PM +1000, Dave Chinner wrote:
> >     "XFS: ihashsize no longer used, option is deprecated.");
> >             } else if (!strcmp(this_char, "osyncisdsync")) {
> > -                   /* no-op, this is now the default */
> >                     cmn_err(CE_WARN,
> > -   "XFS: osyncisdsync is now the default, option is deprecated.");
> > +   "XFS: the osyncisdsync option is deprecated as has no effect.");
> > +           } else if (!strcmp(this_char, "osyncisosync")) {
> > +                   cmn_err(CE_WARN,
> > +   "XFS: the osyncisosync option is deprecated as has no effect.");
> >             } else if (!strcmp(this_char, "irixsgid")) {
> >                     cmn_err(CE_WARN,
> >     "XFS: irixsgid is now a sysctl(2) variable, option is deprecated.");
> 
> Look better as:
> 
>       "XFS: osyncisdsync has no effect, option is deprecated."
>       "XFS: osyncisosync has no effect, option is deprecated."
> 
> so they are consistent with the other deprecated option output.
> I've made this change to the patch i have in my tree....

Sure, fine with me.

<Prev in Thread] Current Thread [Next in Thread>