[Top] [All Lists]

Re: [PATCH 5/6] xfs: simplify xfs_truncate_file

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfs: simplify xfs_truncate_file
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 20 Jul 2010 17:44:42 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100718203926.590752918@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100718203848.927859114@xxxxxxxxxxxxxxxxxxxxxx> <20100718203926.590752918@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Jul 18, 2010 at 04:38:53PM -0400, Christoph Hellwig wrote:
> xfs_truncate_file is only used for truncating quota files.  Move it to
> xfs_qm_syscalls.c so it can be marked static and take advatange of the
> fact by removing the unused page cache validation and taking the iget
> into the helper.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>