xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: remove obsolete osyncisosync mount option

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: remove obsolete osyncisosync mount option
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 20 Jul 2010 17:38:32 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100718203926.229290039@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100718203848.927859114@xxxxxxxxxxxxxxxxxxxxxx> <20100718203926.229290039@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Jul 18, 2010 at 04:38:51PM -0400, Christoph Hellwig wrote:
> Since Linux 2.6.33 the kernel has support for real O_SYNC, which made
> the osyncisosync option a no-op.  Warn the users about this and remove
> the mount flag for it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good, but I think these messages:
> 
> @@ -366,9 +363,11 @@ xfs_parseargs(
>                       cmn_err(CE_WARN,
>       "XFS: ihashsize no longer used, option is deprecated.");
>               } else if (!strcmp(this_char, "osyncisdsync")) {
> -                     /* no-op, this is now the default */
>                       cmn_err(CE_WARN,
> -     "XFS: osyncisdsync is now the default, option is deprecated.");
> +     "XFS: the osyncisdsync option is deprecated as has no effect.");
> +             } else if (!strcmp(this_char, "osyncisosync")) {
> +                     cmn_err(CE_WARN,
> +     "XFS: the osyncisosync option is deprecated as has no effect.");
>               } else if (!strcmp(this_char, "irixsgid")) {
>                       cmn_err(CE_WARN,
>       "XFS: irixsgid is now a sysctl(2) variable, option is deprecated.");

Look better as:

        "XFS: osyncisdsync has no effect, option is deprecated."
        "XFS: osyncisosync has no effect, option is deprecated."

so they are consistent with the other deprecated option output.
I've made this change to the patch i have in my tree....

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>