xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: track AGs with reclaimable inodes in per-ag radix t

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: track AGs with reclaimable inodes in per-ag radix tree
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 19 Jul 2010 10:17:19 +1000
Cc: Alex Elder <aelder@xxxxxxx>, XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <20100716051700.GB29915@xxxxxxxxxxxxx>
References: <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-2-git-send-email-david@xxxxxxxxxxxxx> <1279216900.2054.28.camel@doink> <20100716051700.GB29915@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 16, 2010 at 01:17:00AM -0400, Christoph Hellwig wrote:
> On Thu, Jul 15, 2010 at 01:01:40PM -0500, Alex Elder wrote:
> > Using the same tag represent a perag with reclaimable
> > inodes as the tag representing an inode is reclaimable
> > is nicely consistent...
> 
> Oh, didn't notice that when reviewing it.  Not sure I like it
> too much.  If we ever grow more tags on the perag tree this
> might get rather confusing.

Sure. But it's an in-memory flag so we can change it whenever we
need to. If we grow another tag on the perag tree, we can sort it
out then....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>