| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 16 Jul 2010 01:19:34 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1279154300-2018-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-08-17) |
> - lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP);
> + lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP|KM_NOFS);
KM_NOFS by itself actually is sufficiant. If you want to keep the
KM_SLEEP for documentation purposes at least add some spaces to make
it more redable.
lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS);
Once getting outside of nitpicking territory this looks good to me:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/5] xfs: track AGs with reclaimable inodes in per-ag radix tree, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 4/5] xfs: use GFP_NOFS for page cache allocation, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings, Alex Elder |
| Next by Thread: | Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |