xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: fix unsigned underflow

To: Kulikov Vasiliy <segooon@xxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 15 Jul 2010 17:21:16 -0400
Cc: kernel-janitors@xxxxxxxxxxxxxxx, Alex Elder <aelder@xxxxxxx>, Felix Blyakher <felixb@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <1279219605-12631-1-git-send-email-segooon@xxxxxxxxx>
References: <1279219605-12631-1-git-send-email-segooon@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> below zero. So, check exact expression instead of map_len.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>