xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: simplify and remove xfs_ireclaim

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: simplify and remove xfs_ireclaim
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 15 Jul 2010 13:07:27 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1279154300-2018-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1279154300-2018-1-git-send-email-david@xxxxxxxxxxxxx> <1279154300-2018-3-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2010-07-15 at 10:38 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_ireclaim has to get and put te pag structure because it is only
> called with the inode to reclaim. The one caller of this function
> already has a reference on the pag and a pointer to is, so move the
> radix tree delete to the caller and remove xfs_ireclaim completely.
> This avoids a xfs_perag_get/put on every inode being reclaimed.
> 
> The overhead was noticed in a bug report at:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=16348

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_sync.c |   31 ++++++++++++++++++++++++-
>  fs/xfs/xfs_iget.c           |   53 
> +------------------------------------------
>  fs/xfs/xfs_inode.h          |    2 +-
>  3 files changed, 32 insertions(+), 54 deletions(-)


<Prev in Thread] Current Thread [Next in Thread>