xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: don't block on buffer read errors

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 15 Jul 2010 10:05:52 +1000
Cc: xfs@xxxxxxxxxxx, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20100714182836.GA12108@xxxxxxxxxxxxx>
References: <1279007450-10457-1-git-send-email-david@xxxxxxxxxxxxx> <1279007450-10457-2-git-send-email-david@xxxxxxxxxxxxx> <20100714182836.GA12108@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote:
> Looks good, except that I'd rework the snipplet below
> 
> >     status = xfs_buf_iorequest(bp);
> > -   if (!status && !(flags & XBF_ASYNC))
> > +   if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> >             status = xfs_buf_iowait(bp);
> >     return status;
> 
> as:
> 
>       if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
>               return status;
>       return xfs_buf_iowait(bp);
> 
> to make it a bit more clear.

Make sense. Fixed it up.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>